Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol)!: sync state root rather than signal service's storage root #15671

Merged
merged 56 commits into from
Feb 10, 2024
Merged

feat(protocol)!: sync state root rather than signal service's storage root #15671

merged 56 commits into from
Feb 10, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 7, 2024 •
edited
Loading

verifyMerkleProof in SignalService remains to be re-implemented.

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Feb 8, 2024 1:51pm

@dantaik
Copy link
Contributor Author

dantaik commented Feb 9, 2024 •
edited
Loading

fyi @dantaik if you can hold off on merging this until i fix the tags that would be great. i didn't push the v1.0.0 protocol major release yet which establishes the base API. will take a look tomorrow.

@d1onys1us please remove [do not merge] from the title.

@dantaik dantaik marked this pull request as draft February 9, 2024 05:53
@dantaik dantaik marked this pull request as ready for review February 9, 2024 08:07
@dantaik dantaik requested a review from Brechtpd February 9, 2024 12:52
@dionysuzx dionysuzx changed the title feat(protocol)!: sync state root rather than signal service's storage root [do not merge] feat(protocol): sync state root rather than signal service's storage root [do not merge] Feb 9, 2024
@dionysuzx dionysuzx changed the title feat(protocol): sync state root rather than signal service's storage root [do not merge] feat(protocol): sync state root rather than signal service's storage root Feb 9, 2024
@dionysuzx
Copy link
Collaborator

@dantaik this is okay to merge. lets not worry about breaking changes for now, we will not release the v1.0.0 yet. i will tag bcr audited tag in another way (0.x.y+bcr.audited)

@dantaik dantaik enabled auto-merge (squash) February 10, 2024 02:51
@dantaik dantaik changed the title feat(protocol): sync state root rather than signal service's storage root feat(protocol)!: sync state root rather than signal service's storage root Feb 10, 2024
@dantaik dantaik requested review from adaki2004 and removed request for adaki2004 February 10, 2024 03:18
@dantaik dantaik merged commit ea33e65 into main Feb 10, 2024
14 checks passed
@dantaik dantaik deleted the remove-signal-root branch February 10, 2024 03:19
@github-actions github-actions bot mentioned this pull request Feb 10, 2024
Merged
@davidtaikocha davidtaikocha mentioned this pull request Feb 14, 2024
Merged
@taiko-kitty taiko-kitty mentioned this pull request Mar 1, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dionysuzx dionysuzx dionysuzx approved these changes

@Brechtpd Brechtpd Brechtpd approved these changes

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
area.protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dantaik @dionysuzx @Brechtpd @adaki2004 @davidtaikocha