-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(relayer): two-step bridge + watchdog + full merkle proof #15669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FYI This is just waiting for some changes I've asked Ruby to do with regards to ERC20/721/1155s (now that we have a generic invocation method, the previous method of checking which type of token we have no longer works). |
…ko-mono into a7_relayer_watchdog_updates
KorbinianK
approved these changes
Mar 4, 2024
This was referenced Mar 4, 2024
This was referenced Mar 29, 2024
This was referenced Apr 5, 2024
This was referenced May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the relayer
indexer
subcommand to be able to index eitherMessageSent
orMessageReceived
, add the event name to the queue name to have separate queues for each flow. We will now deploy two relayer indexers for each source-dest chain, to feed either queue (to be either Processed, or checked if they need to be Suspended).Update the relayer
processor
to be able to handle the the newtwo-step
bridge, as well as full merkle proofs: if aproofReceipt
exists onchain, we are in the second step, if it doesnt, we are in the first step. The processor needs to be able to wait after sending the "MessageReceive" call if we are in the first step, and wait to finalize it. Ifi t is in the "MessageExecuted" step, the relayer can return early and acknowledge the queue message.If a relayer exits early after processing a call in the first step, the message needs to be unacknowledged and go back onto the queue, to repeat the process, except detect it now has a ProofReceipt and can be processed without a proof.
Add a new
watchdog
subcommand, which reads from the newMessageReceived
queue, and callsisMessageSent
on the source bridge. If it exists, acknowledge the queue message succesfully. If it doesn't exist, we need to transactsuspend message
on chain for this transaction, and add that to the database for querying via a UI.Add a new migration, repository, interface, implementation, and route to the relayer
API
subcommand for:GET /suspendedTransactions
- list all suspended transactions in a paginated response.increment a Prometheus counter when we suspend, so we can use this for an alert to alert David and I.
Update proof changes with latest signal service/bridge code.
TODO:
Summary by CodeRabbit
suspended_transactions
table.