Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(protocol): imporve bridge _proveSignalReceived and fix genesis test #15641

Merged
merged 6 commits into from
Feb 2, 2024
Merged

fix(protocol): imporve bridge _proveSignalReceived and fix genesis test #15641

merged 6 commits into from
Feb 2, 2024

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Feb 2, 2024

No description provided.

@dantaik dantaik requested review from Brechtpd and adaki2004 February 2, 2024 04:57
@dantaik dantaik marked this pull request as ready for review February 2, 2024 04:57
@vercel Vercel
Copy link

vercel bot commented Feb 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
bridge-ui-v2-a6 ✅ Ready (Inspect) Visit Preview Feb 2, 2024 7:21am

@dantaik dantaik enabled auto-merge February 2, 2024 05:01
@dantaik dantaik requested a review from davidtaikocha February 2, 2024 05:05
@adaki2004
Copy link
Contributor

Seems genesis tests still failing.

@dantaik
Copy link
Contributor Author

dantaik commented Feb 2, 2024

Seems genesis tests still failing.

fixed

@dantaik dantaik added this pull request to the merge queue Feb 2, 2024
Merged via the queue into alpha-6 with commit 15f6995 Feb 2, 2024
13 checks passed
@dantaik dantaik deleted the improve-bridge-fix-genesis-test branch February 2, 2024 07:24
@Brechtpd
Copy link
Contributor

Brechtpd commented Feb 2, 2024 •
edited
Loading

If we want to catch reverts, why don't we just add a try/catch in _proveSignalReceived instead of this approach of manually constructing the calldata any manually doing the call on the address?

EDIT: nevermind, discussion on this #15555 (comment)!

This was referenced Feb 9, 2024
Closed
Merged
@taiko-kitty taiko-kitty mentioned this pull request Mar 1, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Mar 29, 2024
Closed
This was referenced Apr 5, 2024
Closed
Closed
@taiko-kitty taiko-kitty mentioned this pull request Apr 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidtaikocha davidtaikocha davidtaikocha approved these changes

@adaki2004 adaki2004 adaki2004 approved these changes

@Brechtpd Brechtpd Awaiting requested review from Brechtpd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dantaik @adaki2004 @Brechtpd @davidtaikocha