fix(relayer): wait for confirmations before saving event when indexing #15603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha-6 #15603 +/- ##
==========================================
Coverage ? 27.01%
==========================================
Files ? 102
Lines ? 6078
Branches ? 0
==========================================
Hits ? 1642
Misses ? 4256
Partials ? 180
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
KorbinianK
approved these changes
Jan 29, 2024
davidtaikocha
approved these changes
Jan 29, 2024
This was referenced Feb 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are experiencing some very rare (2-4 in 1 million) message ID comparison issues in the relayer indexing, this is most likely due to a re-org on the source chain due to not waiting for confirmations before indexing the event to the database.
As well, due to the removal of the
.Raw.Removedflag check, we have some entries that got Removed due to reorg, but were still being indexed and stored.