-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eventindexer): add indexes for struggling queries #15483
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
cyberhorsey
requested review from
dantaik,
Brechtpd,
davidtaikocha and
RogerLamTd
January 11, 2024 20:51
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## alpha-6 #15483 +/- ##
==========================================
Coverage ? 27.23%
==========================================
Files ? 92
Lines ? 5683
Branches ? 0
==========================================
Hits ? 1548
Misses ? 3972
Partials ? 163
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RogerLamTd
approved these changes
Jan 11, 2024
davidtaikocha
approved these changes
Jan 12, 2024
This was referenced Feb 9, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jolnir is having some data querying and long lived connection issues due to the size of the tables. Before we tackle this on a devops level and introduce database partitioning and other such things, we can pre-meditatively set ourselves up on the next testnet by identifying indexes on struggling queries, and also changing a bunch of our existing queries to use columns that have indexes.