fix(bridge-ui-v2): validate amount only if component is mounted #14757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KorbinianK
requested review from
jscriptcoder,
dionysuzx,
dantaik,
davidtaikocha and
xiaodino
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
davidtaikocha
approved these changes
Sep 20, 2023
dionysuzx
approved these changes
Sep 20, 2023
Merged
KorbinianK
added a commit
that referenced
this pull request
Sep 20, 2023
This was referenced Sep 20, 2023
KorbinianK
added a commit
that referenced
this pull request
Sep 28, 2023
KorbinianK
added a commit
that referenced
this pull request
Sep 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bridge now only validates the amount when the selectedToken store updates, if the amount component is also mounted.