Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correction of node documentation #14398

Closed
tukimi666 opened this issue Aug 7, 2023 · 3 comments
Closed

Correction of node documentation #14398

tukimi666 opened this issue Aug 7, 2023 · 3 comments

Comments

@tukimi666
Copy link

tukimi666 commented Aug 7, 2023

Describe the bug

https://taiko.xyz/docs/guides/run-a-node/run-a-taiko-node
Step 3 on this page.
・L2_ENDPOINT_HTTP
・L2_ENDPOINT_WS
If it were written the way it is now, I would mistakenly think that the L3 setting should be the same URL as the L2.
Shouldn't it be noted in the L3 that an INTERNAL PORT is required as a precaution?
L3 Copying and pasting Alchemy's APIKEY as is did not work.
For example
L2_ENDPOINT_HTTP=http://l2_execution_engine:8545/
L2_ENDPOINT_WS=ws://l2_execution_engine:8546 worked fine.
I don't think the explanation of the L3 configuration is sufficient.

Second.
https://taiko.xyz/docs/guides/run-a-node/enable-a-prover
1step
You should write that it is nano .env.l3 nano .env.
env alone is not sufficient.It is hard to understand if you don't write down to nano.
Thank you for your consideration.

@2manslkh
Copy link
Contributor

2manslkh commented Aug 7, 2023

Thanks for highlighting this. Will make the changes ser

@tukimi666
Copy link
Author

tukimi666 commented Aug 7, 2023

Glad I was helpful!It may take some time, but I will send a pullrequest as well.

@2manslkh
Copy link
Contributor

2manslkh commented Aug 7, 2023

Check out #14400

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants