Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in staking dashboard for Eldfell L3 provers #14394

Closed
Tsubasa-Kasuga opened this issue Aug 7, 2023 · 5 comments
Closed

Bug in staking dashboard for Eldfell L3 provers #14394

Tsubasa-Kasuga opened this issue Aug 7, 2023 · 5 comments
Assignees

Comments

@Tsubasa-Kasuga
Copy link

Describe the bug

There was a bug in the staking dashboard for Eldfell L3 provers.
This staking dashboard was supposed to be for Grimsvotn L2, but Eldfell L3 was also able to connect to it. And when connected to Eldfell L3 and the staking button is pressed, a transaction can be sent.
I think we should originally be prompted to change the network and go to Grimsvotn L2 to prompt the transaction to send the transaction.

Steps to reproduce

  1. Connect the meta mask with Grimsvotn L2.
  2. Switch to Eldfell L3 with Metamask
  3. I get a warning "Not on the right network" on the dashboard.
  4. When I press the "Grimsvotn L2" button on the popup, I get a message that the chain switch was successful, but it is still connected to the Eldfell L3 chain.
  5. Press the STAKE button in this state.
  6. Transaction gets issued on Eldfell L3 network. This is also a problem because the top right corner of the dashboard shows Grimsvotn L2.

Additional context

■staking dashboard
https://staking.l3test.taiko.xyz/

■Corresponding part of the manual
https://taiko.xyz/docs/guides/run-a-node/enable-a-prover#stake-your-ttkoe-eldfell-l3-provers-only

@2manslkh
Copy link
Contributor

2manslkh commented Aug 7, 2023

Can you show the transaction on L3?

My network is correctly switched to Grimsvotn L2 after the pop up

@Tsubasa-Kasuga
Copy link
Author

@2manslkh
Copy link
Contributor

2manslkh commented Aug 7, 2023

Seems like 0xC95... is the contract address for the prover pool on L2 and that there have been a few others who have accidentally transferred eth there

I managed to reproduce the error.

Possible solution:

Check chainId again before allowing user to click on Stake button

cc: @cyberhorsey @davidtaikocha

@cyberhorsey
Copy link
Contributor

Will do, thanka for the bug report

@davidtaikocha
Copy link
Member

Closed by #14447

@github-project-automation github-project-automation bot moved this from 📝 Todo to ✅ Done in Taiko Project Board Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants