-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(website): use cards in guides #14378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionysuzx
previously approved these changes
Aug 4, 2023
dantaik
previously approved these changes
Aug 4, 2023
Co-authored-by: d1onys1us <[email protected]>
Co-authored-by: David <[email protected]> Co-authored-by: Daniel Wang <[email protected]>
…14311) Co-authored-by: David <[email protected]> Co-authored-by: d1onys1us <[email protected]>
…ing.mdx (#14390) Co-authored-by: d1onys1us <[email protected]>
Co-authored-by: d1onys1us <[email protected]>
Co-authored-by: d1onys1us <[email protected]>
dionysuzx
previously approved these changes
Aug 8, 2023
MarcusWentz
suggested changes
Aug 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see the emojis on the guides page and side tabs are changing inconsistently.
Please remove these changes and open a seperate PR for us to review.
dantaik
approved these changes
Aug 9, 2023
dantaik
previously approved these changes
Aug 11, 2023
@MarcusWentz @2manslkh This PR is getting old, could you guys work together to resolve pending feedbacks then review it again? |
dionysuzx
approved these changes
Aug 11, 2023
dantaik
approved these changes
Aug 11, 2023
MarcusWentz
approved these changes
Aug 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.