fix(relayer): fix scanning blocks twice #14047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
requested review from
dantaik,
dionysuzx,
davidtaikocha and
RogerLamTd
RogerLamTd
approved these changes
Jun 23, 2023
dionysuzx
approved these changes
Jun 23, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were encounting "fake" reorgs due to re-scanning the first block of every batch, which was actually the end of the previous batch. we were actually processing "blockBatchSize + 1" batches before due to faulty batching logic, however this was never an issue previously because we allowed duplicate event creation and were not attempting to handle reorgs.