Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(website): add deploy a contract documentation using thirdweb #13935

Merged
merged 8 commits into from
Jul 15, 2023
Merged

feat(website): add deploy a contract documentation using thirdweb #13935

merged 8 commits into from
Jul 15, 2023

Conversation

avneesh0612
Copy link
Contributor

hey! I have added contract documentation using thirdweb. Lmk if you have any questions or the PR needs any changes.

@avneesh0612 avneesh0612 changed the title feat: add deploy a contract documentation using thirdweb feat(website): add deploy a contract documentation using thirdweb Jun 8, 2023
@dionysuzx
Copy link
Collaborator

hello @avneesh0612 thank you for the PR. my only suggestion would be to add this to our current "Deploy a contract" guide: https://taiko.xyz/docs/guides/deploy-a-contract

We have hardhat, foundry, remix in separate tabs like this:
image

we could add an additional tab for thirdweb

@avneesh0612
Copy link
Contributor Author

Ah alright, I will add it there, too. Thanks!

@avneesh0612
Copy link
Contributor Author

added it 🫡

dantaik
dantaik previously approved these changes Jun 14, 2023
@manas8908
Copy link

Easy trick

dionysuzx
dionysuzx previously approved these changes Jul 13, 2023
@dionysuzx dionysuzx requested review from dantaik, saminacodes, dionysuzx and MarcusWentz and removed request for saminacodes July 15, 2023 21:58
@dionysuzx dionysuzx added this pull request to the merge queue Jul 15, 2023
Merged via the queue into taikoxyz:main with commit 4ce016a Jul 15, 2023
@gitpoap-bot
Copy link

gitpoap-bot bot commented Jul 15, 2023

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2023 Taiko Contributor:

GitPOAP: 2023 Taiko Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@github-actions github-actions bot mentioned this pull request Jul 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants