-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(status-page): updates for a3 #13821
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13821 +/- ##
==========================================
- Coverage 47.41% 47.39% -0.03%
==========================================
Files 133 133
Lines 3406 3410 +4
Branches 310 310
==========================================
+ Hits 1615 1616 +1
- Misses 1682 1685 +3
Partials 109 109
*This pull request uses carry forward flags. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
requested review from
dionysuzx,
davidtaikocha,
jscriptcoder,
dantaik and
RogerLamTd
May 26, 2023 08:35
Co-authored-by: David <[email protected]>
RogerLamTd
reviewed
May 26, 2023
Co-authored-by: Roger <[email protected]>
RogerLamTd
previously approved these changes
May 26, 2023
…to status_updates_a3
dionysuzx
approved these changes
May 26, 2023
RogerLamTd
approved these changes
May 26, 2023
davidtaikocha
approved these changes
May 27, 2023
dionysuzx
approved these changes
May 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stats endpoint returns correct values now:
keeping in mind we cant index events before today, since the event signature changed.
our current
proofTimeTarget
is 150, so143
is on point, and average proof reward for today is a more sensible1.1
TKO.