fix(protocol): fix deployonl1 script #13740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
changed the title
Brechtpd
approved these changes
May 10, 2023
davidtaikocha
approved these changes
May 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deployonl1script needs a
--block-gas-limitset with our new plonk verifier, or it fails with reverting. Also, now if we use--via-iron anvil, it hangs, but it works on Geth.As the
taiko-clientadds--via-irmanually, I think its OK to remove from the test here, but if someone wants to dive in and see why via IR fails on anvil, that could be good too.closes #13718