feat(protocol): major protocol upgrade for alpha-3 testnet #13640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jeffery Walsh <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: jeff <[email protected]> Co-authored-by: dave | d1onys1us <[email protected]> Co-authored-by: Brecht Devos <[email protected]> Co-authored-by: D <[email protected]> Co-authored-by: Keszey Dániel <[email protected]> Co-authored-by: adaki2004 <[email protected]> Co-authored-by: Daniel Wang <[email protected]>
dantaik
requested review from
cyberhorsey,
davidtaikocha,
Brechtpd and
adaki2004
and removed request for
cyberhorsey
Codecov Report
@@ Coverage Diff @@
## main #13640 +/- ##
==========================================
+ Coverage 39.51% 44.82% +5.31%
==========================================
Files 135 132 -3
Lines 4042 3534 -508
Branches 506 368 -138
==========================================
- Hits 1597 1584 -13
+ Misses 2341 1849 -492
+ Partials 104 101 -3
*This pull request uses carry forward flags. Click here to find out more.
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
…to major protocol upgrade (#13643) Co-authored-by: David <[email protected]>
Co-authored-by: Daniel Wang <[email protected]>
This reverts commit f338783.
…om one (#13651) Co-authored-by: Daniel Wang <[email protected]>
Brechtpd
previously approved these changes
May 2, 2023
cyberhorsey
previously approved these changes
May 3, 2023
|
I approved this PR because it changed 296 files, and is so big, we will never go back to what is in |
Co-authored-by: Brecht Devos <[email protected]>
Co-authored-by: Brecht Devos <[email protected]>
Co-authored-by: Brecht Devos <[email protected]>
Co-authored-by: Brecht Devos <[email protected]>
Co-authored-by: Brecht Devos <[email protected]>
|
Will fix all comments today for another review. |
Co-authored-by: adaki2004 <[email protected]> Co-authored-by: Dani <[email protected]>
Co-authored-by: Brecht Devos <[email protected]>
|
READY for review again. |
davidtaikocha
approved these changes
May 3, 2023
Brechtpd
approved these changes
May 3, 2023
jscriptcoder
added a commit
that referenced
this pull request
May 3, 2023
Co-authored-by: Jeffery Walsh <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: jeff <[email protected]> Co-authored-by: dave | d1onys1us <[email protected]> Co-authored-by: Brecht Devos <[email protected]> Co-authored-by: D <[email protected]> Co-authored-by: Keszey Dániel <[email protected]> Co-authored-by: adaki2004 <[email protected]> Co-authored-by: Daniel Wang <[email protected]> Co-authored-by: Francisco Ramos <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/TaikoL1LibTokenomicsTestnet.t.sol:TaikoL1WithTestnetConfig