fix(relayer): estimate gas for tx, set gas to 2.5mil if not estimatable. works now.

[cyberhorsey]

No description provided.

[codecov]

Codecov Report

Merging #13271 (b1ecddc) into main (7cd7787) will decrease coverage by 0.12%.
The diff coverage is 51.61%.

@@            Coverage Diff             @@
##             main   #13271      +/-   ##
==========================================
- Coverage   61.61%   61.50%   -0.12%     
==========================================
  Files         117      118       +1     
  Lines        3460     3468       +8     
  Branches      485      485              
==========================================
+ Hits         2132     2133       +1     
- Misses       1244     1249       +5     
- Partials       84       86       +2     

Flag	Coverage Δ		*Carryforward flag
bridge-ui	93.80% <ø> (ø)		Carriedforward from 6954529
protocol	52.37% <ø> (ø)		Carriedforward from 6954529
relayer	64.86% <51.61%> (-0.33%)	⬇️
ui	100.00% <ø> (ø)		Carriedforward from 6954529

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files	Coverage Δ
packages/relayer/message/process_message.go	51.40% <25.00%> (-5.17%)	⬇️
packages/relayer/message/estimate_gas.go	60.00% <60.00%> (ø)
packages/relayer/message/is_profitable.go	100.00% <100.00%> (+17.64%)	⬆️
packages/relayer/http/server.go	96.47% <0.00%> (+2.35%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[RogerLamTd]

Just out of curiosity, is there a specific benefit to separating estimate gas and isProfitable? @cyberhorsey

[cyberhorsey]

Just out of curiosity, is there a specific benefit to separating estimate gas and isProfitable? @cyberhorsey

Not only are they two different domain problems that should be unrelated, it lets us handle the errors from them separately. For instance now we don't even run the isProfitable code if the CLI flag for isProfitable isnt set, and now if the estimateGas code doesn't return us a good number, we set a large limit (because it seems unable to estimate cost for deploying an ERC20 when necessary)

[RogerLamTd]

Just out of curiosity, is there a specific benefit to separating estimate gas and isProfitable? @cyberhorsey

Not only are they two different domain problems that should be unrelated, it lets us handle the errors from them separately. For instance now we don't even run the isProfitable code if the CLI flag for isProfitable isnt set, and now if the estimateGas code doesn't return us a good number, we set a large limit (because it seems unable to estimate cost for deploying an ERC20 when necessary)

Gotcha, so we're leaving the flag as false for this coming testnet entirely then