Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): make download solc script can run outside the protocol dir #13263

Merged
merged 1 commit into from
Mar 7, 2023

Conversation

alexshliu
Copy link
Contributor

@alexshliu alexshliu commented Mar 6, 2023

Make the script run outside the protocol directory, which is used in CI scripts, so we don't have to go into the protocol directory (cd taiko-mono/package/protocol) and then exit (cd -)

@alexshliu alexshliu self-assigned this Mar 6, 2023
@alexshliu alexshliu changed the title fix: make download solc script can run outside the protocol dir fix(protocol): make download solc script can run outside the protocol dir Mar 6, 2023
@codecov
Copy link

codecov bot commented Mar 6, 2023

Codecov Report

Merging #13263 (c074599) into main (72d152b) will increase coverage by 0.17%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #13263      +/-   ##
==========================================
+ Coverage   61.50%   61.67%   +0.17%     
==========================================
  Files         117      117              
  Lines        3460     3460              
  Branches      485      485              
==========================================
+ Hits         2128     2134       +6     
+ Misses       1249     1242       -7     
- Partials       83       84       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 93.80% <ø> (ø) Carriedforward from 912c155
protocol 52.48% <ø> (+0.33%) ⬆️
relayer 65.18% <ø> (ø) Carriedforward from 912c155
ui 100.00% <ø> (ø) Carriedforward from 912c155

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alexshliu alexshliu marked this pull request as ready for review March 6, 2023 12:07
@dantaik dantaik added this pull request to the merge queue Mar 7, 2023
Merged via the queue into main with commit 7cd7787 Mar 7, 2023
@dantaik dantaik deleted the fix/script branch March 7, 2023 13:30
@github-actions github-actions bot mentioned this pull request Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants