-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): re-implement bridge receive check #13134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dionysuzx
requested changes
Feb 10, 2023
Co-authored-by: dave | d1onys1us <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #13134 +/- ##
==========================================
+ Coverage 62.57% 62.74% +0.17%
==========================================
Files 114 114
Lines 3220 3224 +4
Branches 435 439 +4
==========================================
+ Hits 2015 2023 +8
+ Misses 1129 1124 -5
- Partials 76 77 +1
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
davidtaikocha
approved these changes
Feb 10, 2023
dionysuzx
approved these changes
Feb 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation is slightly different from the previous implementation in that we all the resolve to return empty values. It does't has security issues compared to the previous one.
I also allow the owner() in the receive just in case.