Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): temporarily force an oracle prover to be the first prover #13070

Merged
merged 14 commits into from
Jan 31, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 29, 2023

This is to enable alpha-2 testnet has permissioned proposers and permissionless provers. When ZKPs are not comprehensive, malicious provers may submit verifiable but invalid ZKPs, in this PR we force a special prover to always be the first prover without verifying its ZKP, effectively using its block-hash to assert all following ZKPs.

@dantaik dantaik requested a review from davidtaikocha January 29, 2023 13:35
@dantaik dantaik changed the title feat(protocol): temporarily allow a special prover to be the first prover feat(protocol): temporarily force a special prover to be the first prover Jan 29, 2023
@dantaik dantaik marked this pull request as ready for review January 29, 2023 13:42
@codecov
Copy link

codecov bot commented Jan 29, 2023

Codecov Report

Merging #13070 (a69474c) into main (2d93c95) will decrease coverage by 0.37%.
The diff coverage is 9.75%.

@@            Coverage Diff             @@
##             main   #13070      +/-   ##
==========================================
- Coverage   64.84%   64.47%   -0.37%     
==========================================
  Files         112      112              
  Lines        3095     3122      +27     
  Branches      384      396      +12     
==========================================
+ Hits         2007     2013       +6     
- Misses       1012     1033      +21     
  Partials       76       76              
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 12cba14
protocol 55.94% <9.75%> (-0.68%) ⬇️
relayer 69.10% <ø> (+0.17%) ⬆️ Carriedforward from 12cba14
ui 100.00% <ø> (ø) Carriedforward from 12cba14

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/libs/LibProving.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibVerifying.sol 11.90% <0.00%> (-1.43%) ⬇️
...ckages/protocol/contracts/libs/LibSharedConfig.sol 0.00% <ø> (ø)
packages/protocol/contracts/libs/LibZKP.sol 0.00% <ø> (ø)
.../contracts/test/L1/TestTaikoL1EnableTokenomics.sol 0.00% <0.00%> (ø)
...ackages/protocol/contracts/test/L1/TestTaikoL2.sol 0.00% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 9.23% <100.00%> (ø)
...ackages/protocol/contracts/test/L1/TestTaikoL1.sol 87.87% <100.00%> (+0.37%) ⬆️
...cts/test/L1/TestTaikoL2EnablePublicInputsCheck.sol 100.00% <100.00%> (ø)
packages/relayer/indexer/service.go 75.53% <0.00%> (ø)
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik requested a review from cyberhorsey January 29, 2023 14:05
@dantaik dantaik changed the title feat(protocol): temporarily force a special prover to be the first prover feat(protocol): temporarily force an oracle prover to be the first prover Jan 30, 2023
@dantaik dantaik requested a review from davidtaikocha January 30, 2023 06:07
@cyberhorsey cyberhorsey enabled auto-merge (squash) January 30, 2023 18:27
@dantaik dantaik requested a review from davidtaikocha January 31, 2023 00:36
@dantaik dantaik disabled auto-merge January 31, 2023 02:53
@cyberhorsey cyberhorsey merged commit d7401a2 into main Jan 31, 2023
@cyberhorsey cyberhorsey deleted the special_prover branch January 31, 2023 02:57
@github-actions github-actions bot mentioned this pull request Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants