-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): temporarily force an oracle prover
to be the first prover
#13070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dantaik
changed the title
feat(protocol): temporarily allow a special prover to be the first prover
feat(protocol): temporarily force a special prover to be the first prover
Jan 29, 2023
Codecov Report
@@ Coverage Diff @@
## main #13070 +/- ##
==========================================
- Coverage 64.84% 64.47% -0.37%
==========================================
Files 112 112
Lines 3095 3122 +27
Branches 384 396 +12
==========================================
+ Hits 2007 2013 +6
- Misses 1012 1033 +21
Partials 76 76
*This pull request uses carry forward flags. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
dantaik
changed the title
feat(protocol): temporarily force a special prover to be the first prover
feat(protocol): temporarily force an Jan 30, 2023
oracle prover
to be the first prover
davidtaikocha
approved these changes
Jan 30, 2023
cyberhorsey
approved these changes
Jan 30, 2023
davidtaikocha
approved these changes
Jan 31, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to enable alpha-2 testnet has permissioned proposers and permissionless provers. When ZKPs are not comprehensive, malicious provers may submit verifiable but invalid ZKPs, in this PR we force a special prover to always be the first prover without verifying its ZKP, effectively using its block-hash to assert all following ZKPs.