Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): implement Bridge.isMessageFailed #13004

Merged
merged 11 commits into from
Jan 21, 2023
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 20, 2023

On the source chain of a message, function isMessageFailed can verify if a message has been failed on the destination chain.

A test shall be added later in a separate PR.

@dantaik dantaik changed the title feat(protocol): impl and test Bridge.isMessageFailed feat(protocol): implement Bridge.isMessageFailed Jan 20, 2023
@dantaik dantaik requested a review from cyberhorsey January 20, 2023 15:21
@dantaik dantaik requested a review from RogerLamTd January 20, 2023 15:43
@dantaik dantaik marked this pull request as ready for review January 20, 2023 15:44
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #13004 (efc48ec) into main (07debb7) will decrease coverage by 0.53%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #13004      +/-   ##
==========================================
- Coverage   66.41%   65.89%   -0.53%     
==========================================
  Files         112      112              
  Lines        3052     3064      +12     
  Branches      363      368       +5     
==========================================
- Hits         2027     2019       -8     
- Misses        948      969      +21     
+ Partials       77       76       -1     
Flag Coverage Δ *Carryforward flag
bridge-ui 92.61% <ø> (ø) Carriedforward from 07debb7
protocol 58.34% <0.00%> (-0.95%) ⬇️
relayer 69.10% <ø> (ø) Carriedforward from 07debb7
ui 100.00% <ø> (ø) Carriedforward from 07debb7

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/bridge/Bridge.sol 51.85% <0.00%> (-4.15%) ⬇️
...s/protocol/contracts/bridge/libs/LibBridgeData.sol 100.00% <ø> (ø)
...protocol/contracts/bridge/libs/LibBridgeStatus.sol 60.00% <0.00%> (-40.00%) ⬇️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 89.47% <0.00%> (-10.53%) ⬇️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

cyberhorsey
cyberhorsey previously approved these changes Jan 20, 2023
RogerLamTd
RogerLamTd previously approved these changes Jan 20, 2023
@dantaik dantaik dismissed stale reviews from RogerLamTd and cyberhorsey via 6aa87af January 21, 2023 00:00
@dantaik dantaik marked this pull request as draft January 21, 2023 00:14
@dantaik
Copy link
Contributor Author

dantaik commented Jan 21, 2023

@davidtaikocha somehow integration & genesis tests are failing. Can you take a look?

@dantaik dantaik requested a review from davidtaikocha January 21, 2023 02:05
@davidtaikocha
Copy link
Member

davidtaikocha commented Jan 21, 2023

@davidtaikocha somehow integration & genesis tests are failing. Can you take a look?

Opened a PR to fix this: #13006 , looks like go-ethereum pushed a new latest tag image 10 hours ago, but they didn't release a new version of go-ehtereum (+ corresponding change logs )... and that newly pushed latest tag image can not be started successfully, so i changed the image tag to the current latest version tag v1.10.26 in that PR for now.

@dantaik dantaik marked this pull request as ready for review January 21, 2023 04:10
@dantaik dantaik enabled auto-merge (squash) January 21, 2023 04:11
@dantaik dantaik merged commit 45153d9 into main Jan 21, 2023
@dantaik dantaik deleted the protocol_release_tokens branch January 21, 2023 09:41
@github-actions github-actions bot mentioned this pull request Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants