Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix an occasional error in test:tokenomics #12950

Merged
merged 3 commits into from
Jan 16, 2023

Conversation

davidtaikocha
Copy link
Member

@davidtaikocha davidtaikocha commented Jan 15, 2023

ref:

After some debugging, looks like its because hardhat mocha's top level describe runs the children describes in parallel (including their beforeEachs), which sometimes makes the tests running into an unknown state.

@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Merging #12950 (6fbf5c9) into main (59276fe) will decrease coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main   #12950      +/-   ##
==========================================
- Coverage   66.67%   66.47%   -0.20%     
==========================================
  Files         113      113              
  Lines        3034     3034              
  Branches      356      356              
==========================================
- Hits         2023     2017       -6     
- Misses        935      941       +6     
  Partials       76       76              
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from 59276fe
protocol 59.23% <ø> (-0.38%) ⬇️
relayer 69.10% <ø> (ø) Carriedforward from 59276fe
ui 100.00% <ø> (ø) Carriedforward from 59276fe

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 83.13% <0.00%> (-7.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik enabled auto-merge (squash) January 15, 2023 08:42
@RogerLamTd RogerLamTd changed the title fix(protocol): fix an occantional error in test:tokenomics fix(protocol): fix an occasional error in test:tokenomics Jan 16, 2023
@dantaik dantaik merged commit 005364c into main Jan 16, 2023
@dantaik dantaik deleted the fix-an-error-in-test-token branch January 16, 2023 20:02
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants