Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): Fix bug in getProposedBlock #11679

Merged
merged 7 commits into from
Jan 10, 2023
Merged

fix(protocol): Fix bug in getProposedBlock #11679

merged 7 commits into from
Jan 10, 2023

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jan 7, 2023

getProposedBlock current doesn't check input id's boundary.

@dantaik dantaik marked this pull request as ready for review January 7, 2023 14:50
@vercel
Copy link

vercel bot commented Jan 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
bridge-ui 🔄 Building (Inspect) Jan 7, 2023 at 2:59PM (UTC)

@dantaik dantaik marked this pull request as draft January 7, 2023 15:00
@dantaik
Copy link
Contributor Author

dantaik commented Jan 7, 2023

@d1onys1us It seems somehow this commit of yours breaks the solidity workflow (https://github.com/taikoxyz/taiko-mono/actions/runs/3862638351/jobs/6584339122):

davidtaikocha
davidtaikocha previously approved these changes Jan 7, 2023
cyberhorsey
cyberhorsey previously approved these changes Jan 9, 2023
@cyberhorsey cyberhorsey dismissed stale reviews from davidtaikocha and themself via e8ada7b January 10, 2023 00:28
@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Merging #11679 (e9df913) into main (b54a37e) will increase coverage by 0.20%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main   #11679      +/-   ##
==========================================
+ Coverage   67.68%   67.88%   +0.20%     
==========================================
  Files         109      109              
  Lines        2940     2943       +3     
  Branches      355      356       +1     
==========================================
+ Hits         1990     1998       +8     
+ Misses        874      868       -6     
- Partials       76       77       +1     
Flag Coverage Δ *Carryforward flag
bridge-ui 95.05% <ø> (ø) Carriedforward from e8ada7b
protocol 61.55% <0.00%> (+0.41%) ⬆️
relayer 69.10% <ø> (ø) Carriedforward from e8ada7b
ui 100.00% <ø> (ø) Carriedforward from e8ada7b

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
packages/protocol/contracts/L1/TaikoL1.sol 39.21% <0.00%> (ø)
...ckages/protocol/contracts/L1/libs/LibProposing.sol 4.83% <0.00%> (-0.25%) ⬇️
...es/protocol/contracts/thirdparty/LibMerkleTrie.sol 90.36% <0.00%> (+7.22%) ⬆️
...ges/protocol/contracts/libs/LibAnchorSignature.sol 100.00% <0.00%> (+10.52%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dantaik dantaik merged commit a6a596c into main Jan 10, 2023
@dantaik dantaik deleted the fix_bug_in_protocol branch January 10, 2023 02:17
@github-actions github-actions bot mentioned this pull request Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants