Save bootstrap details to JSON file #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbeza
force-pushed
the
feat/save-bootstrap-info
branch
5 times, most recently
from
320e0dd
to
e8ac35d
Compare
pbeza
force-pushed
the
feat/save-bootstrap-info
branch
from
e8ac35d
to
ce7203f
Compare
dyxushuai
reviewed
Jan 19, 2024
| println!("Public key: 0x{}", key_pair.public_key()); | ||
| let new_instance = public_key_to_address(&key_pair.public_key()); | ||
| println!("Instance address: {}", new_instance); | ||
| let quote = get_sgx_quote()?; | ||
| let bootstrap_details_file_path = global_opts.config_dir.join(BOOTSTRAP_INFO_FILENAME); |
There was a problem hiding this comment.
It's not a good idea to store the privacy data into config path
There was a problem hiding this comment.
I partially agree: users' secrets/profile data are typically saved in $HOME/.config configuration directory instead of system-wide /etc. I fixed that – let me know if know is better (if not, pls suggest some other directory). 👍🏼
pbeza
force-pushed
the
feat/save-bootstrap-info
branch
from
74a0a5b
to
baad571
Compare
johntaiko
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.