Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation of #[pinned_drop] #88

Closed
taiki-e opened this issue Sep 11, 2019 · 0 comments · Fixed by #201
Closed

Improve documentation of #[pinned_drop] #88

taiki-e opened this issue Sep 11, 2019 · 0 comments · Fixed by #201
Assignees
@taiki-e
Labels
A-drop Area: #[pinned_drop] and Drop C-documentation Category: related to documentation.

Comments

@taiki-e
Copy link
Owner

taiki-e commented Sep 11, 2019

Code has short descriptions(1, 2) but we need to document why this requires a macro.

See: #86 (comment)
@taiki-e taiki-e changed the title Improve #[pinned_drop] documentation Improve documentation of #[pinned_drop] Sep 11, 2019
@taiki-e taiki-e mentioned this issue Sep 11, 2019
Merged
@taiki-e taiki-e added this to the v0.4 milestone Sep 23, 2019
@taiki-e taiki-e added C-documentation Category: related to documentation. A-drop Area: #[pinned_drop] and Drop labels Sep 23, 2019
@taiki-e taiki-e self-assigned this Sep 23, 2019
@taiki-e taiki-e added the C-enhancement Category: A new feature or an improvement for an existing one label Sep 24, 2019
@taiki-e taiki-e removed this from the v0.4 milestone Sep 24, 2019
@taiki-e taiki-e mentioned this issue May 6, 2020
Merged
@bors bors bot closed this as completed in d991a8a May 6, 2020
@bors bors bot closed this as completed in #201 May 6, 2020
@taiki-e taiki-e removed the C-enhancement Category: A new feature or an improvement for an existing one label Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taiki-e taiki-e

Labels
A-drop Area: #[pinned_drop] and Drop C-documentation Category: related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve documentation and diagnostics of #[pinned_drop] taiki-e/pin-project
1 participant
@taiki-e