Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass GITHUB_TOKEN for cargo binstall for per-ip rate limit #561

Open
anatawa12 opened this issue Jun 25, 2024 · 3 comments · May be fixed by #556
Open

pass GITHUB_TOKEN for cargo binstall for per-ip rate limit #561

anatawa12 opened this issue Jun 25, 2024 · 3 comments · May be fixed by #556

Comments

@anatawa12
Copy link

In some case, cargo binstall will face API per-ip rate limit on github actions runner (due to shared ip address).

As a solution, I want install-action to have an feature to pass github.token to cargo binstall as a GITHUB_TOKEN environment variable or parameter.

https://github.com/vrc-get/vrc-get/actions/runs/9664217883/job/26658335596#step:7:1

As a workaround, we can specify env: { GITHUB_TOKEN: ${{ github.token }} }

@anatawa12 anatawa12 changed the title pass GITHUB_TOKEN for cargo binstall for fater installation pass GITHUB_TOKEN for cargo binstall for per-ip rate limit Jun 25, 2024
@taiki-e
Copy link
Owner

taiki-e commented Jun 25, 2024

See #556 for the previous discussion.

@simonsan
Copy link
Contributor

Same problems here, whenever I work on editing/improving a workflow and need to run it more often, like every 3-5 Minutes, and make a lot of requests - this would be indeed helpful.

@NobodyXu
Copy link
Collaborator

NobodyXu commented Nov 11, 2024

cc @taiki-e maybe we should reopen the PR to pass secrets.GITHUB_TOKEN?

I also wish GitHub provide more relaxed rate limit for the read-only APIs, but I understand that they don't have that much resources to burn on.

@taiki-e taiki-e linked a pull request Nov 12, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants