Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't find missing line #380

Open
jendrikw opened this issue Aug 4, 2024 · 3 comments
Open

can't find missing line #380

jendrikw opened this issue Aug 4, 2024 · 3 comments
Labels
C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream)

Comments

@jendrikw
Copy link

jendrikw commented Aug 4, 2024

The text and the html report for my project https://github.com/jendrikw/clearurls show that one line in rules.rs is missing coverage, but I can't find it. I tried --show-missing-lines, but that did nothing.

I'm on commit 12f36764 and this is the output I get from running cargo llvm-cov --all-features --show-missing-lines:

info: cargo-llvm-cov currently setting cfg(coverage); you can opt-out it by passing --no-cfg-coverage
   Compiling clearurls v0.0.1 (/home/jendrik/dev/rust/clearurls)
    Finished `test` profile [unoptimized + debuginfo] target(s) in 8.21s
     Running unittests src/lib.rs (target/llvm-cov-target/debug/deps/clearurls-b84d5d7032e5c877)

running 17 tests
test deserialize_utils::tests::test_deserialize_map_as_vec_error ... ok
test tests::test_from_file_invalid_json ... ok
test deserialize_utils::tests::test_deserialize_regex_set_error ... ok
test tests::test_from_invalid_path ... ok
test deserialize_utils::tests::test_deserialize_regex ... ok
test deserialize_utils::tests::test_deserialize_regex_vec_error ... ok
test tests::test_from_str_invalid_json ... ok
test tests::test_from_read_file ... ok
test tests::test_from_read_vec ... ok
test tests::test_from_path ... ok
test tests::test_raw_rules_produce_invalid_url ... ok
test tests::test_referral_marketing_setter ... ok
test tests::test_invalid_redirection ... ok
test tests::test_invalid_urldecode ... ok
test tests::test_remove_fields_from_url_errors ... ok
test tests::test_raw_rules_unchanged ... ok
test tests::test_strip_referral_marketing ... ok

test result: ok. 17 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.02s

     Running tests/test_markdown.rs (target/llvm-cov-target/debug/deps/test_markdown-4a2b43eb5f36c406)

running 1 test
test test_markdown ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.31s

     Running tests/test_single_url.rs (target/llvm-cov-target/debug/deps/test_single_url-d76fe224866ae094)

running 1 test
test test_single_url ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 2.31s

Filename                      Regions    Missed Regions     Cover   Functions  Missed Functions  Executed       Lines      Missed Lines     Cover    Branches   Missed Branches     Cover
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
deserialize_utils.rs               49                 2    95.92%          12                 0   100.00%         142                 0   100.00%           0                 0         -
lib.rs                             84                 3    96.43%          16                 0   100.00%         143                 0   100.00%           0                 0         -
rules.rs                           80                 5    93.75%          15                 0   100.00%          88                 1    98.86%           0                 0         -
-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
TOTAL                             213                10    95.31%          43                 0   100.00%         373                 1    99.73%           0                 0         -

(Unrelated, but tips on how to identify uncovered regions would also be appreciated)

@jendrikw
Copy link
Author

jendrikw commented Aug 4, 2024

Here is the text output if that's helpful: https://github.com/jendrikw/clearurls/actions/runs/10229901824/job/28304099435

@narner90
Copy link

narner90 commented Aug 9, 2024

Having this same exact issue issue, version is llvm version 19.1.0-rust-1.82.0-nightly

@taiki-e
Copy link
Owner

taiki-e commented Aug 10, 2024

I feel this is a similar issue with #324.

@taiki-e taiki-e added the C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream) label Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-upstream-bug Category: This is a bug of compiler or dependencies (the fix may require action in the upstream)
Projects
None yet
Development

No branches or pull requests

3 participants