Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifying arbitrary --objects #367

Open
rcoh opened this issue May 1, 2024 · 1 comment
Open

Add support for specifying arbitrary --objects #367

rcoh opened this issue May 1, 2024 · 1 comment
Labels
C-enhancement Category: A new feature or an improvement for an existing one C-question Category: A question

Comments

@rcoh
Copy link

rcoh commented May 1, 2024

I recently added coverage testing for duchess which has a somewhat complicated setup of regular unit tests & and subproject containing ui tests.

This meant I had to go manually pick up all of the --object invocations that were needed which (I think) made it impossible to use cargo llvm-cov. Ideally, I'd be able to use a combination of https://github.com/taiki-e/cargo-llvm-cov?tab=readme-ov-file#get-coverage-of-external-tests and this additional configuration behavior to be able to use this tool directly.

Is there a better way of doing this that would have meant I could have used cargo llvm-cov directly without changes? Or is some sort of additional configuration required.

@taiki-e
Copy link
Owner

taiki-e commented May 1, 2024

I think you can use LLVM_COV_FLAGS environment-variable, but I'm okay with adding a specific option for out-of-target-dir object files.

@taiki-e taiki-e added C-question Category: A question C-enhancement Category: A new feature or an improvement for an existing one labels May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: A new feature or an improvement for an existing one C-question Category: A question
Projects
None yet
Development

No branches or pull requests

2 participants