fix(kit): `InputNumber` has rounding problems on blur with float large numbers #9974

nsbarsukov · 2024-12-12T10:07:56Z

Open https://taiga-ui.dev/components/input-number/API?thousandSeparator=_&precision=2
Paste
```
123_456_789_012_345.67
```
Blur

Previous behavior: 123_456_789_012_345.69
New behavior: 123_456_789_012_345.67

Fixes #9970

lumberjack-bot · 2024-12-12T10:08:52Z

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

projects/legacy/components/input-number/input-number.component.ts

github-actions · 2024-12-12T10:12:56Z

Visit the preview URL for this PR (updated for commit a057a15):

https://taiga-previews-demo--pr9974-format-number-bug-demo-lkz9tkc2.web.app

_{(expires Fri, 13 Dec 2024 13:59:12 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37}

codecov · 2024-12-12T10:15:36Z

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.18%. Comparing base (16c4f3a) to head (a057a15).
Report is 3 commits behind head on main.

Files with missing lines	Patch %	Lines
projects/cdk/utils/math/round.ts	66.66%	1 Missing and 1 partial ⚠️
.../components/input-number/input-number.component.ts	50.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9974      +/-   ##
==========================================
- Coverage   66.19%   66.18%   -0.02%     
==========================================
  Files        1214     1214              
  Lines       15696    15700       +4     
  Branches     2320     2343      +23     
==========================================
+ Hits        10390    10391       +1     
+ Misses       4981     4977       -4     
- Partials      325      332       +7

Flag	Coverage Δ
summary	`66.18% <62.50%> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

bundlemon · 2024-12-12T10:23:29Z

BundleMon

Files updated (1)

Status	Path	Size	Limits
✅	demo/browser/main.(hash).js	304.08KB (+103B +0.03%)	+10%

Unchanged files (4)

Status	Path	Size	Limits
✅	demo/browser/vendor.(hash).js	260.19KB	+10%
✅	demo/browser/runtime.(hash).js	43.93KB	+10%
✅	demo/browser/styles.(hash).css	19.63KB	+10%
✅	demo/browser/polyfills.(hash).js	11.18KB	+10%

Total files change +100B +0.02%

Groups updated (1)

Status	Path	Size	Limits
✅	demo/browser/*..js	7.38MB (+100B 0%)	-

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

…arge numbers

github-actions · 2024-12-12T11:49:16Z

Playwright test results

2 failed
1885 passed
1 flaky
84 skipped

Details

Open report ↗︎
1972 tests across 69 suites
31 minutes, 16 seconds
a057a15

Failed tests

chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › does not mutate already valid too large number on blur
webkit › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › does not mutate already valid too large number on blur

Flaky tests

webkit › tests/demo/demo.pw.spec.ts › Demo › /navigation/app-bar

Skipped tests

webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with saved cards
webkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › expired field should be clickable after reset of prefilled value
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-example"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll to "tui-doc-code"
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › anchor links navigation works › scroll after click on link with anchor
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [light mode]
webkit › tests/addon-doc/navigation.pw.spec.ts › Navigation › getting started / [dark mode]
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Submenu
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Form control
webkit › tests/core/data-list/data-list.pw.spec.ts › DataList › Complex
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 320x480 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 720x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1024x900 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Prompt
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Pristine form does not show confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Dirty form shows confirmation
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with confirmation works › Form is reset to pristine
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › A dialog and a nested dialog are open correctly
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Mobile dialog works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Dialog with directive works
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › 1620x1024 › Show simple + custom button
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 320x480
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 720x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1024x900
webkit › tests/core/dialogs/dialogs.pw.spec.ts › Dialogs › Prompt - 1620x1024
webkit › tests/core/surface/surface.pw.spec.ts › Surface › Layers
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Closes dropdown on click on overlay
webkit › tests/kit/dropdown-hover/dropdown-hover.pw.spec.ts › DropdownHover › Examples › With DropdownMobile › Opens mobile version of dropdown on the 2nd time click
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the beginning of the track changes only nearest (left) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click on the end of the track changes only nearest (right) slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › change selected range on click › click between two thumbs triggers only nearest thumb
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on right slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Right increases by one step (after focus on left slider)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › pressing of Arrow Left decreases by one step (after setting right thumb active via click)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set left thumb more than right thumb (by Arrow Right)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › basic range (from 0 to 1000 with 250 steps). Initial value [0, 250] › cannot set right thumb less than left thumb (by ArrowLeft)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowUp increases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › ArrowDown decreases value of the focused slider
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the LEFT slider MORE THAN position of the RIGHT slider (by ArrowUp)
webkit › tests/kit/range/range.pw.spec.ts › TuiRange › examples page › keyboard interactions › range with keySteps (from 0 to 1M) with 8 steps. Initial value [0, 100_000] › cannot set position of the RIGHT slider LESS THAN position of the LEFT slider (by ArrowDown)
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › decrease value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 1 step
webkit › tests/kit/slider/slider.pw.spec.ts › Slider › programmatically change value › ngModel › increase value by 2 steps
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › no extra margin after the last tab
webkit › tests/kit/tabs/tabs.pw.spec.ts › Tabs › Examples › complex › shows only a single dropdown for the nested item (with [tuiDropdown]) inside more section
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show settings in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › Show hint in aside
webkit › tests/layout/navigation.pw.spec.ts › Navigation › A12y
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is visible when the input is focused
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for s size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for m size
webkit › tests/legacy/input-time/input-time.pw.spec.ts › InputTime › API › items are passed › the dropdown is configured for l size
webkit › tests/legacy/multi-select/multi-select.pw.spec.ts › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=s
webkit › tests/legacy/multi-select/multi-select.pw.spec.ts › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=m
webkit › tests/legacy/multi-select/multi-select.pw.spec.ts › MultiSelect › Examples › Multiselect inside dialog with different textfield sizes › multiselect inside dialog with tuiTextfieldSize=l
webkit › tests/legacy/multi-select/multi-select.pw.spec.ts › MultiSelect › Examples › does not overflow arrow icon by many tags
webkit › tests/legacy/multi-select/multi-select.pw.spec.ts › MultiSelect › Examples › multi-select with data list with label
webkit › tests/legacy/multi-select/multi-select.pw.spec.ts › MultiSelect › Examples › multi-select with data list without label

.cspell.json

projects/cdk/utils/math/round.ts

nsbarsukov self-assigned this Dec 12, 2024

nsbarsukov commented Dec 12, 2024

View reviewed changes

projects/legacy/components/input-number/input-number.component.ts Outdated Show resolved Hide resolved

fix(legacy): InputNumber has rounding problems on blur with float l…

b5dcfa9

…arge numbers

nsbarsukov force-pushed the format-number-bug branch from 9a21575 to b5dcfa9 Compare December 12, 2024 10:56

nsbarsukov marked this pull request as ready for review December 12, 2024 12:08

nsbarsukov requested a review from a team as a code owner December 12, 2024 12:08

nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team December 12, 2024 12:08

waterplea approved these changes Dec 12, 2024

View reviewed changes

.cspell.json Show resolved Hide resolved

projects/cdk/utils/math/round.ts Outdated Show resolved Hide resolved

chore: fix review comment

9816161

nsbarsukov commented Dec 12, 2024

View reviewed changes

projects/cdk/utils/math/round.ts Outdated Show resolved Hide resolved

chore: fix again

a057a15

splincode approved these changes Dec 12, 2024

View reviewed changes

github-actions bot added the ready to merge label Dec 12, 2024

splincode merged commit 9ec1e7b into main Dec 12, 2024
35 of 36 checks passed

splincode deleted the format-number-bug branch December 12, 2024 14:53

taiga-family-bot mentioned this pull request Dec 23, 2024

🚀 Release/v4.19.0 #10046

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(kit): `InputNumber` has rounding problems on blur with float large numbers #9974

fix(kit): `InputNumber` has rounding problems on blur with float large numbers #9974

nsbarsukov commented Dec 12, 2024

lumberjack-bot bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

codecov bot commented Dec 12, 2024 •

edited

Loading

bundlemon bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

fix(kit): InputNumber has rounding problems on blur with float large numbers #9974

fix(kit): InputNumber has rounding problems on blur with float large numbers #9974

Conversation

nsbarsukov commented Dec 12, 2024

lumberjack-bot bot commented Dec 12, 2024 • edited Loading

Pull request was closed ✔️

github-actions bot commented Dec 12, 2024 • edited Loading

codecov bot commented Dec 12, 2024 • edited Loading

Codecov Report

bundlemon bot commented Dec 12, 2024 • edited Loading

BundleMon

github-actions bot commented Dec 12, 2024 • edited Loading

Playwright test results

Details

fix(kit): `InputNumber` has rounding problems on blur with float large numbers #9974

fix(kit): `InputNumber` has rounding problems on blur with float large numbers #9974

lumberjack-bot bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading

codecov bot commented Dec 12, 2024 •

edited

Loading

bundlemon bot commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Dec 12, 2024 •

edited

Loading