Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): InputDate{Range|Time} + input[tuiTextfieldLegacy] + tuiTextfieldFiller has CD problems #9932

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Dec 6, 2024

Fixes #9642

image

@nsbarsukov nsbarsukov self-assigned this Dec 6, 2024
Copy link

lumberjack-bot bot commented Dec 6, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Visit the preview URL for this PR (updated for commit a032978):

https://taiga-previews-demo--pr9932-legacy-textfield-filler-cd-js19va85.web.app

(expires Tue, 10 Dec 2024 11:26:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 6, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
303.9KB (+22B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.94KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +22B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.38MB (+22B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nsbarsukov nsbarsukov force-pushed the legacy-textfield-filler-cd-bug branch from 1402e05 to 7c7ce9e Compare December 6, 2024 10:49
Copy link
Contributor

github-actions bot commented Dec 6, 2024

Playwright test results

failed  4 failed
passed  977 passed

Details

report  Open report ↗︎
stats  981 tests across 69 suites
duration  8 minutes, 37 seconds
commit  a032978

Failed tests

chromium › tests/legacy/input-date/input-date.pw.spec.ts › InputDate › Examples › with input[tuiTextfieldLegacy] inside › filler has no change detection problems
chromium › tests/legacy/input-date/input-date.pw.spec.ts › InputDate › Examples › correct filler display for size
chromium › tests/legacy/input-date-range/input-date-range.pw.spec.ts › InputDateRange › Examples › with input[tuiTextfieldLegacy] inside › filler has no change detection problems
chromium › tests/legacy/input-date-time/input-date-time.pw.spec.ts › InputDateTime › Examples › with input[tuiTextfieldLegacy] inside › filler has no change detection problems

@nsbarsukov nsbarsukov marked this pull request as ready for review December 6, 2024 15:08
@nsbarsukov nsbarsukov requested a review from a team as a code owner December 6, 2024 15:08
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team December 6, 2024 15:08
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

Attention: Patch coverage is 61.53846% with 5 lines in your changes missing coverage. Please review.

Project coverage is 75.26%. Comparing base (4a26b1a) to head (a032978).
Report is 773 commits behind head on main.

Files with missing lines Patch % Lines
...nts/input-date-range/input-date-range.component.ts 66.66% 0 Missing and 2 partials ⚠️
...nents/input-date-time/input-date-time.component.ts 50.00% 2 Missing ⚠️
...gacy/components/input-date/input-date.component.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9932      +/-   ##
==========================================
- Coverage   75.68%   75.26%   -0.43%     
==========================================
  Files        1216     1249      +33     
  Lines       19068    19607     +539     
  Branches     2091     1992      -99     
==========================================
+ Hits        14432    14757     +325     
- Misses       4592     4809     +217     
+ Partials       44       41       -3     
Flag Coverage Δ
summary 75.26% <61.53%> (-0.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nsbarsukov nsbarsukov merged commit 026d13c into main Dec 9, 2024
24 of 26 checks passed
@nsbarsukov nsbarsukov deleted the legacy-textfield-filler-cd-bug branch December 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants