Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Icon fix for old safari #9917

Merged
merged 1 commit into from
Dec 4, 2024
Merged

fix(core): Icon fix for old safari #9917

merged 1 commit into from
Dec 4, 2024

Conversation

vladimirpotekhin
Copy link
Member

issue

autoprefixer adds -webkit-mask-composite: source-in, xor as a fallback for safari 14 and older, it only works when applying two masks

mask-composite: intersect works the same way in safari 15. (only when applying two masks)

solution:

use mask-composite: intersect only when we have two masks on ::after element - in icon-badge directive

Снимок экрана 2024-12-04 в 16 36 05

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner December 4, 2024 14:15
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team December 4, 2024 14:15
Copy link

lumberjack-bot bot commented Dec 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Visit the preview URL for this PR (updated for commit 66b2bd1):

https://taiga-previews-demo--pr9917-fix-old-safari-icons-demo-3mr3tjpw.web.app

(expires Thu, 05 Dec 2024 14:26:25 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 4, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
303.79KB +10%
demo/browser/vendor.(hash).js
259.99KB +10%
demo/browser/runtime.(hash).js
43.78KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.32MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 4, 2024

Playwright test results

passed  975 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  8 minutes, 51 seconds
commit  66b2bd1

@splincode splincode merged commit 8c3a228 into main Dec 4, 2024
28 checks passed
@splincode splincode deleted the fix-old-safari-icons branch December 4, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants