Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(legacy): InputNumber has bad support of dynamic postfix #9899

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix(legacy): InputNumber has bad support of dynamic postfix #9899

merged 1 commit into from
Dec 3, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov self-assigned this Dec 3, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Dec 3, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 6142807):

https://taiga-previews-demo--pr9899-input-number-postfix-fix-d-csa15y6k.web.app

(expires Wed, 04 Dec 2024 14:53:35 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

@nsbarsukov nsbarsukov marked this pull request as ready for review December 3, 2024 14:15
@nsbarsukov nsbarsukov requested a review from a team as a code owner December 3, 2024 14:15
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team December 3, 2024 14:15
@bundlemon BundleMon
Copy link

bundlemon bot commented Dec 3, 2024 •
edited
Loading

BundleMon

Files updated (1)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 303.79KB (-23B -0.01%) +10%
Unchanged files (4)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 259.97KB +10%
✅ demo/browser/runtime.(hash).js
 43.78KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change -23B 0%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.32MB (-23B 0%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 3, 2024 •
edited
Loading

Playwright test results

failed  1 failed
passed  974 passed

Details

report  Open report ↗︎
stats  975 tests across 69 suites
duration  9 minutes, 2 seconds
commit  6142807

Failed tests

chromium › tests/legacy/input-number/input-number.pw.spec.ts › InputNumber › API › Infinite precision

@splincode splincode force-pushed the input-number-postfix-fix branch from b1a396f to 6142807 Compare December 3, 2024 14:49
@splincode splincode merged commit fefdcff into main Dec 3, 2024
25 of 26 checks passed
@splincode splincode deleted the input-number-postfix-fix branch December 3, 2024 16:01
@taiga-family-bot taiga-family-bot mentioned this pull request Dec 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@splincode splincode splincode approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@vladimirpotekhin vladimirpotekhin Awaiting requested review from vladimirpotekhin vladimirpotekhin is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - Dynamic tuiTextfieldPostfix issue
3 participants
@nsbarsukov @waterplea @splincode