Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(legacy): limit tui-tag width to 80% to avoid wrapping in selects #9886

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

splincode
Copy link
Member

Fixes #4255

Before

image

After

image

@splincode splincode requested a review from a team as a code owner December 2, 2024 15:27
@splincode splincode requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team December 2, 2024 15:27
Copy link

lumberjack-bot bot commented Dec 2, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Visit the preview URL for this PR (updated for commit a97519c):

https://taiga-previews-demo--pr9886-splincode-fix-issues-4255-bxg2qpgc.web.app

(expires Tue, 10 Dec 2024 15:14:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Dec 2, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
303.94KB (+38B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.19KB +10%
demo/browser/runtime.(hash).js
43.93KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +36B +0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.38MB (+169B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Playwright test results

failed  2 failed
passed  979 passed

Details

report  Open report ↗︎
stats  981 tests across 69 suites
duration  9 minutes, 34 seconds
commit  a97519c

Failed tests

chromium › tests/demo/demo.pw.spec.ts › Demo › /components/multi-select
chromium › tests/legacy/input-tag/input-tag.pw.spec.ts › InputTag › Examples › errors of invalid control are shown correctly

@splincode splincode force-pushed the splincode/fix/issues/4255 branch from 51aa7ba to 1804b1f Compare December 3, 2024 10:50
@splincode splincode requested a review from waterplea December 3, 2024 10:50
@splincode splincode force-pushed the splincode/fix/issues/4255 branch from 1804b1f to 0882e86 Compare December 9, 2024 13:15
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.26%. Comparing base (248e3d0) to head (a97519c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9886   +/-   ##
=======================================
  Coverage   75.26%   75.26%           
=======================================
  Files        1249     1249           
  Lines       19607    19607           
  Branches     2155     2076   -79     
=======================================
  Hits        14757    14757           
- Misses       4804     4806    +2     
+ Partials       46       44    -2     
Flag Coverage Δ
summary 75.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode requested a review from waterplea December 9, 2024 13:25
@splincode splincode force-pushed the splincode/fix/issues/4255 branch from 0882e86 to dcb771f Compare December 9, 2024 15:10
@splincode splincode force-pushed the splincode/fix/issues/4255 branch from dcb771f to a97519c Compare December 9, 2024 15:10
@splincode splincode merged commit 54f5c65 into main Dec 9, 2024
25 of 26 checks passed
@splincode splincode deleted the splincode/fix/issues/4255 branch December 9, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - Empty line in multi-select in case of long tags
3 participants