Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): Carousel fix dragging in chrome #9864

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Conversation

vladimirpotekhin
Copy link
Member

Fixes #7036

@vladimirpotekhin vladimirpotekhin requested a review from a team as a code owner November 28, 2024 14:11
@vladimirpotekhin vladimirpotekhin requested review from MarsiBarsi, waterplea, nsbarsukov and mdlufy and removed request for a team November 28, 2024 14:12
Copy link

lumberjack-bot bot commented Nov 28, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Visit the preview URL for this PR (updated for commit e9301a8):

https://taiga-previews-demo--pr9864-carousel-fix-4-demo-4i2kxitq.web.app

(expires Sat, 30 Nov 2024 13:11:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37

Copy link

bundlemon bot commented Nov 28, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
304.08KB +10%
demo/browser/vendor.(hash).js
260.11KB +10%
demo/browser/runtime.(hash).js
43.79KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change -1B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.32MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Nov 28, 2024

Playwright test results

failed  1 failed
passed  973 passed

Details

report  Open report ↗︎
stats  974 tests across 69 suites
duration  9 minutes, 28 seconds
commit  e9301a8

Failed tests

chromium › tests/deep/deep-select.pw.spec.ts › Deep / Select › /components/icon

@vladimirpotekhin vladimirpotekhin merged commit 6b1f985 into main Nov 29, 2024
26 of 27 checks passed
@vladimirpotekhin vladimirpotekhin deleted the carousel-fix-4 branch November 29, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - The slide index changing randomly when you trying to flip through the slide by dragging
3 participants