Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): FocusTrap has race condition problems #9759

Merged
merged 2 commits into from
Nov 19, 2024
Merged

Conversation

nsbarsukov
Copy link
Member

Fixes #8067

@nsbarsukov nsbarsukov self-assigned this Nov 14, 2024
Copy link

lumberjack-bot bot commented Nov 14, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

Visit the preview URL for this PR (updated for commit eb0f1b4):

https://taiga-previews--pr9759-focus-trap-races-wy06csfr.web.app

(expires Fri, 15 Nov 2024 13:15:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@nsbarsukov nsbarsukov marked this pull request as ready for review November 14, 2024 13:19
@nsbarsukov nsbarsukov requested a review from a team as a code owner November 14, 2024 13:19
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team November 14, 2024 13:19
Copy link

bundlemon bot commented Nov 14, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
299.77KB (+20B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
260.09KB +10%
demo/browser/runtime.(hash).js
43.9KB +10%
demo/browser/styles.(hash).css
19.63KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +20B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.33MB (+20B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode merged commit d84b437 into main Nov 19, 2024
29 checks passed
@splincode splincode deleted the focus-trap-races branch November 19, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

🐞 - TuiSheetDialog marks control as touched if after closing the first dialog the next one is opened
3 participants