Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(addon-mobile): DropdownMobile is not compatible with DropdownHover #9736

Merged
merged 8 commits into from
Nov 14, 2024
Merged

fix(addon-mobile): DropdownMobile is not compatible with DropdownHover #9736

merged 8 commits into from
Nov 14, 2024

Conversation

nsbarsukov
Copy link
Member

Fixes #9589

@nsbarsukov nsbarsukov self-assigned this Nov 12, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 12, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit d226d2e):

https://taiga-previews--pr9736-dropdown-hover-fix-zdcxyi3t.web.app

(expires Fri, 15 Nov 2024 07:36:03 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 12, 2024 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 299.75KB (+91B +0.03%) +10%
✅ demo/browser/runtime.(hash).js
 43.9KB (+39B +0.09%) +10%
Unchanged files (3)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 260.09KB +10%
✅ demo/browser/styles.(hash).css
 19.63KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +130B +0.02%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.33MB (+6.05KB +0.08%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@nsbarsukov nsbarsukov marked this pull request as ready for review November 12, 2024 08:25
@nsbarsukov nsbarsukov requested a review from a team as a code owner November 12, 2024 08:25
@nsbarsukov nsbarsukov requested review from MarsiBarsi, waterplea, vladimirpotekhin and mdlufy and removed request for a team November 12, 2024 08:25
@vladimirpotekhin vladimirpotekhin self-requested a review November 12, 2024 11:34
@vladimirpotekhin vladimirpotekhin self-requested a review November 12, 2024 12:49
@nsbarsukov nsbarsukov requested a review from splincode November 13, 2024 14:20
@nsbarsukov nsbarsukov merged commit b57149a into main Nov 14, 2024
25 checks passed
@nsbarsukov nsbarsukov deleted the dropdown-hover-fix branch November 14, 2024 08:08
@taiga-family-bot taiga-family-bot mentioned this pull request Nov 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@splincode splincode splincode approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner automatically assigned from taiga-family/core-team

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner automatically assigned from taiga-family/core-team

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - DropdownHover is not working correctly.
3 participants
@nsbarsukov @splincode @vladimirpotekhin