Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-charts): fix division by zero in LineChart #9722

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

simonenkof
Copy link
Contributor

@simonenkof simonenkof commented Nov 9, 2024

Fixes #9720

@simonenkof simonenkof requested a review from a team as a code owner November 9, 2024 12:34
@simonenkof simonenkof requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 9, 2024 12:34
Copy link

lumberjack-bot bot commented Nov 9, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Nov 9, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
299.35KB +10%
demo/browser/vendor.(hash).js
260.06KB +10%
demo/browser/runtime.(hash).js
43.52KB +10%
demo/browser/styles.(hash).css
19.6KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.25MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23%. Comparing base (4a26b1a) to head (b0c99cd).
Report is 616 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9722      +/-   ##
==========================================
- Coverage   75.68%   75.23%   -0.46%     
==========================================
  Files        1216     1247      +31     
  Lines       19068    19580     +512     
  Branches     2091     2141      +50     
==========================================
+ Hits        14432    14731     +299     
- Misses       4592     4803     +211     
- Partials       44       46       +2     
Flag Coverage Δ
summary 75.23% <ø> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vladimirpotekhin vladimirpotekhin merged commit c12a315 into taiga-family:main Nov 11, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - "Division by 0" resize method returns 0 at initialization in LineChart
3 participants