Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(addon-mobile): TuiPullToRefreshService fix pulling$ stream by calling TUI_PULL_TO_REFRESH_LOADED.next() on onPull event #9716

Conversation

nezar-khamidekh
Copy link
Contributor

@nezar-khamidekh nezar-khamidekh commented Nov 7, 2024

Fixes #8327

I guess that the problem was with event loop tasks order (micro/macro), because it was wrong values (wrong last value) for the percent property inside TuiMobileLoader... components. The last value was 100, but must be 0 and because of that the tui-loader didn't disappear.

At the same time, everything was really fine through calling TUI_PULL_TO_REFRESH_LOADED.next() inside setTimeout (like described in the issue), that's why I decided to add some scheduler for the stream in TuiPullToRefreshService.

Throttletime didn't make any sense and I decided to use debounceTime with tuiZonefreeScheduler.

@nezar-khamidekh nezar-khamidekh requested a review from a team as a code owner November 7, 2024 12:33
@nezar-khamidekh nezar-khamidekh requested review from MarsiBarsi, waterplea, nsbarsukov, vladimirpotekhin and mdlufy and removed request for a team November 7, 2024 12:33
Copy link

lumberjack-bot bot commented Nov 7, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.23%. Comparing base (4a26b1a) to head (40b2044).
Report is 619 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9716      +/-   ##
==========================================
- Coverage   75.68%   75.23%   -0.46%     
==========================================
  Files        1216     1247      +31     
  Lines       19068    19582     +514     
  Branches     2091     2070      -21     
==========================================
+ Hits        14432    14732     +300     
- Misses       4592     4806     +214     
  Partials       44       44              
Flag Coverage Δ
summary 75.23% <100.00%> (-0.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Nov 7, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
299.35KB +10%
demo/browser/vendor.(hash).js
260.06KB +10%
demo/browser/runtime.(hash).js
43.52KB +10%
demo/browser/styles.(hash).css
19.6KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

No change in files bundle size

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.25MB (+11B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@nezar-khamidekh nezar-khamidekh changed the title fix(addon-mobile): TuiPullToRefreshService pulling$ stream with synchronously behaviour of TUI_PULL_TO_REFRESH_LOADED fix(addon-mobile): TuiPullToRefreshService fix pulling$ stream by calling TUI_PULL_TO_REFRESH_LOADED next on onPull event Nov 7, 2024
@nezar-khamidekh nezar-khamidekh changed the title fix(addon-mobile): TuiPullToRefreshService fix pulling$ stream by calling TUI_PULL_TO_REFRESH_LOADED next on onPull event fix(addon-mobile): TuiPullToRefreshService fix pulling$ stream by calling TUI_PULL_TO_REFRESH_LOADED.next() on onPull event Nov 7, 2024
@vladimirpotekhin vladimirpotekhin force-pushed the fix/tui-pull-to-refresh-loaded-on-pulled-sync branch from b3218e5 to 707cdb1 Compare November 7, 2024 12:50
@splincode splincode merged commit 3b978be into taiga-family:main Nov 12, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

🐞 - TUI_PULL_TO_REFRESH_LOADED token dose not work when is used in onPull event synchronously
4 participants