Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(legacy): InputDateRange double backspace to clear textfield #9707

Merged
merged 6 commits into from
Nov 12, 2024
Merged

fix(legacy): InputDateRange double backspace to clear textfield #9707

merged 6 commits into from
Nov 12, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Nov 6, 2024 •
edited
Loading

Fixes #7960

After press backspace:
Before (main) ← Diff → After (local)
image

@mdlufy mdlufy requested a review from a team as a code owner November 6, 2024 14:12
@mdlufy mdlufy requested review from MarsiBarsi, waterplea, nsbarsukov and vladimirpotekhin and removed request for a team November 6, 2024 14:12
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Nov 6, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 6, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit ac43dd7):

https://taiga-previews--pr9707-mdlufy-input-date-ra-w2ssh8ey.web.app

(expires Fri, 08 Nov 2024 08:30:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Nov 6, 2024 •
edited
Loading

BundleMon

Unchanged files (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 299KB +10%
✅ demo/browser/vendor.(hash).js
 260.04KB +10%
✅ demo/browser/runtime.(hash).js
 43.46KB +10%
✅ demo/browser/styles.(hash).css
 19.6KB +10%
✅ demo/browser/polyfills.(hash).js
 11.18KB +10%

Total files change +2B 0%

Unchanged groups (1)
Status Path Size Limits
✅ demo/browser/*..js
 7.24MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@vladimirpotekhin vladimirpotekhin merged commit c80cadc into main Nov 12, 2024
25 of 26 checks passed
@vladimirpotekhin vladimirpotekhin deleted the mdlufy/input-date-range-backspace branch November 12, 2024 09:16
@taiga-family-bot taiga-family-bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner automatically assigned from taiga-family/core-team

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov nsbarsukov is a code owner automatically assigned from taiga-family/core-team

Assignees

@mdlufy mdlufy

Labels
ready to merge
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐞 - InputDateRange textfield clears after double press "Backspace"
4 participants
@mdlufy @waterplea @vladimirpotekhin @taiga-family-bot