-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(legacy): InputDate
incorrect value after backspace
#9650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request was closed ✔️All saved screenshots (for current PR) were deleted 🗑️ |
Visit the preview URL for this PR (updated for commit f6caf49): https://taiga-previews--pr9650-mdlufy-input-date-ed-a6wwtxca.web.app (expires Wed, 06 Nov 2024 08:30:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +13B 0% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
mdlufy
changed the title
[DRAFT] fix(legacy):
fix(legacy): Oct 31, 2024
InputDate
incorrect value after backspaceInputDate
incorrect value after backspace
nsbarsukov
reviewed
Oct 31, 2024
mdlufy
requested review from
MarsiBarsi,
waterplea and
vladimirpotekhin
and removed request for
a team
October 31, 2024 20:17
vladimirpotekhin
approved these changes
Nov 5, 2024
waterplea
approved these changes
Nov 5, 2024
nsbarsukov
approved these changes
Nov 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
value.length === DATE_FILLER_LENGTH (10)
, value may contain not only date string, but also letters string.This was not taken into account and as a result, an attempt was made to parse the date from the string and the value
01.01.0000
was obtainedincorrect-value.mov