Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy): InputDate incorrect value after backspace #9650

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Oct 31, 2024

When value.length === DATE_FILLER_LENGTH (10), value may contain not only date string, but also letters string.

this.value =
            value.length !== DATE_FILLER_LENGTH
                ? null
                : TuiDay.normalizeParse(value, this.dateFormat.mode);

This was not taken into account and as a result, an attempt was made to parse the date from the string and the value 01.01.0000 was obtained

incorrect-value.mov

Copy link

lumberjack-bot bot commented Oct 31, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Oct 31, 2024

Visit the preview URL for this PR (updated for commit f6caf49):

https://taiga-previews--pr9650-mdlufy-input-date-ed-a6wwtxca.web.app

(expires Wed, 06 Nov 2024 08:30:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Oct 31, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
298.66KB (+13B 0%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
259.74KB +10%
demo/browser/runtime.(hash).js
43.42KB +10%
demo/browser/styles.(hash).css
19.61KB +10%
demo/browser/polyfills.(hash).js
11.18KB +10%

Total files change +13B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
7.23MB (+13B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy changed the title [DRAFT] fix(legacy): InputDate incorrect value after backspace fix(legacy): InputDate incorrect value after backspace Oct 31, 2024
@mdlufy mdlufy requested a review from nsbarsukov October 31, 2024 15:10
@mdlufy mdlufy marked this pull request as ready for review October 31, 2024 20:17
@mdlufy mdlufy requested a review from a team as a code owner October 31, 2024 20:17
@mdlufy mdlufy requested review from MarsiBarsi, waterplea and vladimirpotekhin and removed request for a team October 31, 2024 20:17
@mdlufy mdlufy merged commit 6a10460 into main Nov 5, 2024
26 checks passed
@mdlufy mdlufy deleted the mdlufy/input-date-editing branch November 5, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants