Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): unsubscribe from pan service when directive is destroyed #9021

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

splincode
Copy link
Member

No description provided.

Copy link

lumberjack-bot bot commented Sep 14, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 14, 2024
Copy link
Contributor

github-actions bot commented Sep 14, 2024

Visit the preview URL for this PR (updated for commit c596ec7):

https://taiga-previews--pr9021-splincode-refactor-p-gbsbrj8j.web.app

(expires Wed, 18 Sep 2024 14:56:56 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Sep 14, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
285.75KB +10%
demo/browser/vendor.(hash).js
216.46KB +10%
demo/browser/runtime.(hash).js
42.25KB +10%
demo/browser/styles.(hash).css
13.51KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change -2B 0%

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
7.01MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode force-pushed the splincode/refactor-pan branch 3 times, most recently from 350d29e to 505bfe4 Compare September 17, 2024 14:52
@splincode splincode force-pushed the splincode/refactor-pan branch from 505bfe4 to c596ec7 Compare September 17, 2024 14:52
@splincode splincode merged commit 5ce088a into main Sep 18, 2024
29 checks passed
@splincode splincode deleted the splincode/refactor-pan branch September 18, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants