Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): Card fix tuiLabel title font weight when tuiLabel is placed inside a card #8931

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

hakimio
Copy link
Contributor

@hakimio hakimio commented Sep 10, 2024

Fixes tuiLabel title font weight in the following case:

<div
    tuiCardLarge
    tuiSurface="elevated"
>
    <label tuiLabel>
        <span tuiTitle>
            <span tuiSubtitle>Foo</span>
            Bar
        </span>
    </label>
</div>

Copy link

lumberjack-bot bot commented Sep 10, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.69%. Comparing base (43c0ebb) to head (4ddd60b).
Report is 1575 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8931      +/-   ##
==========================================
+ Coverage   70.19%   75.69%   +5.49%     
==========================================
  Files        1460     1216     -244     
  Lines       15934    19064    +3130     
  Branches     2292     1972     -320     
==========================================
+ Hits        11185    14430    +3245     
- Misses       4369     4592     +223     
+ Partials      380       42     -338     
Flag Coverage Δ
summary 75.69% <ø> (+5.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Sep 10, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
283.36KB (-21B -0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.48KB +10%
demo/browser/runtime.(hash).js
42.17KB +10%
demo/browser/styles.(hash).css
12.81KB +10%
demo/browser/polyfills.(hash).js
11.2KB +10%

Total files change -24B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.99MB (-21B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea waterplea merged commit b7e871c into taiga-family:main Sep 10, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants