Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-commerce): ThumbnailCard add <img> support #8789

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

mdlufy
Copy link
Collaborator

@mdlufy mdlufy commented Sep 2, 2024

Close #

Copy link

lumberjack-bot bot commented Sep 2, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Sep 2, 2024
Copy link
Contributor

github-actions bot commented Sep 2, 2024

Visit the preview URL for this PR (updated for commit a5fcf04):

https://taiga-previews--pr8789-mdlufy-thumbnail-car-8oqaydb0.web.app

(expires Tue, 03 Sep 2024 15:52:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@mdlufy mdlufy changed the title feat(addon-commerce): ThumbnailCard add <img> support [WIP] feat(addon-commerce): ThumbnailCard add <img> support Sep 2, 2024
Copy link

bundlemon bot commented Sep 2, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/styles.(hash).css
11.61KB (-17B -0.14%) +10%
demo/browser/main.(hash).js
282.44KB (-777B -0.27%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.46KB +10%
demo/browser/runtime.(hash).js
42.04KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change -799B -0.14%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.92MB (-24.72KB -0.35%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@mdlufy mdlufy force-pushed the mdlufy/thumbnail-card branch from abf1c74 to a5fcf04 Compare September 2, 2024 15:48
@mdlufy mdlufy changed the title [WIP] feat(addon-commerce): ThumbnailCard add <img> support feat(addon-commerce): ThumbnailCard add <img> support Sep 2, 2024
@waterplea waterplea merged commit 9fdb499 into main Sep 2, 2024
27 checks passed
@waterplea waterplea deleted the mdlufy/thumbnail-card branch September 2, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants