Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): Navigation add Drawer #8757

Merged
merged 5 commits into from
Sep 2, 2024
Merged

feat(layout): Navigation add Drawer #8757

merged 5 commits into from
Sep 2, 2024

Conversation

waterplea
Copy link
Collaborator

Close #

Copy link

lumberjack-bot bot commented Aug 29, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions github-actions bot added the v4 4.0 candidate label Aug 29, 2024
Copy link
Contributor

github-actions bot commented Aug 29, 2024

Visit the preview URL for this PR (updated for commit 84b1e8a):

https://taiga-previews--pr8757-drawer-856d261e.web.app

(expires Tue, 03 Sep 2024 14:49:53 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Aug 29, 2024

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
42.03KB (+21B +0.05%) +10%
demo/browser/main.(hash).js
282.7KB (-70B -0.02%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.46KB +10%
demo/browser/styles.(hash).css
11.62KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change -49B -0.01%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.91MB (+4.95KB +0.07%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@waterplea waterplea merged commit cc64434 into main Sep 2, 2024
26 of 27 checks passed
@waterplea waterplea deleted the drawer branch September 2, 2024 15:08
@hakimio
Copy link
Contributor

hakimio commented Sep 2, 2024

@waterplea how does the new drawer component compares to the old addon-mobile Sidebar?

@waterplea
Copy link
Collaborator Author

@hakimio new drawer is specifically for the burger type menu in Navigation set of components. We also plan to add a more general use right side drawer later. Sidebar from addon-mobile is more like a basic container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

5 participants