Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kit): segmented subscription to control value changes #8574

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

Vadim2805
Copy link
Contributor

Closes #

Copy link

lumberjack-bot bot commented Aug 16, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.06%. Comparing base (43c0ebb) to head (97ebdbb).
Report is 1341 commits behind head on main.

Files Patch % Lines
...ts/kit/components/segmented/segmented.directive.ts 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8574      +/-   ##
==========================================
- Coverage   70.19%   67.06%   -3.14%     
==========================================
  Files        1460     1171     -289     
  Lines       15934    15047     -887     
  Branches     2292     2067     -225     
==========================================
- Hits        11185    10091    -1094     
- Misses       4369     4776     +407     
+ Partials      380      180     -200     
Flag Coverage Δ
summary 67.06% <50.00%> (-3.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Aug 16, 2024

BundleMon

Unchanged files (5)
Status Path Size Limits
demo/browser/main.(hash).js
280.7KB +10%
demo/browser/vendor.(hash).js
216.25KB +10%
demo/browser/runtime.(hash).js
41.52KB +10%
demo/browser/styles.(hash).css
11.56KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

No change in files bundle size

Unchanged groups (1)
Status Path Size Limits
demo/browser/*..js
6.79MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

projects/kit/components/segmented/segmented.directive.ts Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
projects/kit/components/segmented/segmented.directive.ts Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
@splincode splincode changed the title fix(kit): Segmented subscription to control value changes fix(kit): segmented subscription to control value changes Aug 19, 2024
@splincode splincode merged commit e6cf175 into taiga-family:main Aug 19, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants