Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add @taiga-ui/icons-material #8454

Merged
merged 1 commit into from
Aug 12, 2024
Merged

feat: add @taiga-ui/icons-material #8454

merged 1 commit into from
Aug 12, 2024

Conversation

splincode
Copy link
Member

@splincode splincode commented Aug 10, 2024 •
edited
Loading

image

@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Aug 10, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 10, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 82072d0):

https://taiga-previews--pr8454-splincode-material-8t4trx47.web.app

(expires Tue, 13 Aug 2024 12:26:13 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

@bundlemon BundleMon
Copy link

bundlemon bot commented Aug 10, 2024 •
edited
Loading

BundleMon

Files updated (2)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 278.2KB (+146B +0.05%) +10%
✅ demo/browser/runtime.(hash).js
 41.28KB (+88B +0.21%) +10%
Unchanged files (3)
Status Path Size Limits
✅ demo/browser/vendor.(hash).js
 216.27KB +10%
✅ demo/browser/styles.(hash).css
 11.56KB +10%
✅ demo/browser/polyfills.(hash).js
 11.21KB +10%

Total files change +234B +0.04%

Groups updated (1)
Status Path Size Limits
✅ demo/browser/*..js
 6.7MB (+39.11KB +0.57%) -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history | Target branch size history

@splincode splincode added the v4 4.0 candidate label Aug 10, 2024
@waterplea
Copy link
Collaborator

Let's name it @taiga-ui/icons-material. So that all icon packages are alphabetically close. Not sure about 3 words, should we keep -design?

@splincode splincode force-pushed the splincode/material branch 2 times, most recently from e03d52a to a33ab77 Compare August 10, 2024 21:05
@splincode splincode changed the title feat: add @taiga-ui/material-design-icons feat: add @taiga-ui/icons-material Aug 10, 2024
@splincode
Copy link
Member Author

@waterplea fixed

@splincode splincode force-pushed the splincode/material branch 10 times, most recently from 5ebda58 to 070395a Compare August 12, 2024 11:16
@splincode splincode merged commit 3315a29 into main Aug 12, 2024
26 of 27 checks passed
@splincode splincode deleted the splincode/material branch August 12, 2024 16:09
@splincode splincode linked an issue Aug 12, 2024 that may be closed by this pull request
🚀 - Easier support for FontAwesome or Material Icon Sets #2340
Closed
This was referenced Aug 13, 2024
Merged
Merged
@taiga-family-bot taiga-family-bot mentioned this pull request Aug 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@waterplea waterplea waterplea approved these changes

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi

@nsbarsukov nsbarsukov Awaiting requested review from nsbarsukov

@mdlufy mdlufy Awaiting requested review from mdlufy

Assignees

@splincode splincode

Labels
ready to merge v4 4.0 candidate
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🚀 - Easier support for FontAwesome or Material Icon Sets
3 participants
@splincode @waterplea @vladimirpotekhin