Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(addon-doc): improve ui for link to sample #8406

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

splincode
Copy link
Member

@splincode splincode commented Aug 7, 2024

image

My idea from google project https://google.github.io/zx/getting-started

image

Copy link

lumberjack-bot bot commented Aug 7, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Aug 7, 2024

Visit the preview URL for this PR (updated for commit 335f09a):

https://taiga-previews--pr8406-splincode-feat-addon-nn4ijnfd.web.app

(expires Thu, 29 Aug 2024 10:04:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 20bbff1ad19772ecf9c5134a84c0641b0d776f4a

Copy link

bundlemon bot commented Aug 7, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
282.19KB (+113B +0.04%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.4KB +10%
demo/browser/runtime.(hash).js
42KB +10%
demo/browser/styles.(hash).css
11.6KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +113B +0.02%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.9MB (+113B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@splincode splincode added the v4 4.0 candidate label Aug 7, 2024
@splincode
Copy link
Member Author

@nsbarsukov

@splincode splincode force-pushed the splincode/feat/addon-doc/link branch from 8e83984 to e52327f Compare August 14, 2024 18:21
@splincode splincode force-pushed the splincode/feat/addon-doc/link branch from e52327f to 30db5fb Compare August 22, 2024 13:36
@splincode splincode requested a review from waterplea August 26, 2024 10:51
@splincode splincode force-pushed the splincode/feat/addon-doc/link branch from 30db5fb to 0be6616 Compare August 28, 2024 09:59
@splincode splincode force-pushed the splincode/feat/addon-doc/link branch from 0be6616 to 335f09a Compare August 28, 2024 10:00
@splincode splincode enabled auto-merge (squash) August 28, 2024 10:10
@splincode splincode merged commit e5beb47 into main Aug 28, 2024
26 of 27 checks passed
@splincode splincode deleted the splincode/feat/addon-doc/link branch August 28, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants