Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): prevent disabled date selection for calendar-range #8329

Merged

Conversation

p-ivannikov
Copy link
Contributor

Closes #3708

Copy link

lumberjack-bot bot commented Aug 4, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

codecov bot commented Aug 4, 2024

Codecov Report

Attention: Patch coverage is 25.92593% with 20 lines in your changes missing coverage. Please review.

Project coverage is 67.03%. Comparing base (43c0ebb) to head (00ca1e6).
Report is 1273 commits behind head on main.

Files Patch % Lines
...ponents/calendar-range/calendar-range.component.ts 25.92% 18 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8329      +/-   ##
==========================================
- Coverage   70.19%   67.03%   -3.16%     
==========================================
  Files        1460     1172     -288     
  Lines       15934    15051     -883     
  Branches     2292     2068     -224     
==========================================
- Hits        11185    10090    -1095     
- Misses       4369     4780     +411     
+ Partials      380      181     -199     
Flag Coverage Δ
summary 67.03% <25.92%> (-3.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

bundlemon bot commented Aug 4, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
278.39KB (+202B +0.07%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
216.27KB +10%
demo/browser/runtime.(hash).js
41.28KB +10%
demo/browser/styles.(hash).css
11.56KB +10%
demo/browser/polyfills.(hash).js
11.21KB +10%

Total files change +202B +0.04%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
6.7MB (+202B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

@p-ivannikov p-ivannikov force-pushed the 4x-cr-prevent-disabled-selection branch 2 times, most recently from fba8754 to 3e64a52 Compare August 12, 2024 15:42
@splincode splincode added the v4 4.0 candidate label Aug 12, 2024
@p-ivannikov p-ivannikov force-pushed the 4x-cr-prevent-disabled-selection branch from 3e64a52 to 00ca1e6 Compare August 13, 2024 04:23
@p-ivannikov p-ivannikov requested a review from waterplea August 13, 2024 04:44
@splincode splincode merged commit 951779d into taiga-family:main Aug 13, 2024
28 checks passed
This was referenced Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

🚀 - Dont allow to select disabled dates in calendar
3 participants