Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kit): InputDateTime with [min] / [max] distorts value on click #7636

Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix(kit): InputDateTime with [min] / [max] distorts value on click #7636

merged 1 commit into from
Jun 5, 2024

Conversation

nsbarsukov
Copy link
Member

@nsbarsukov nsbarsukov commented Jun 5, 2024 •
edited
Loading

Closes #7586

@nsbarsukov nsbarsukov added the v3 label Jun 5, 2024
@lumberjack-bot lumberjack-bot
Copy link

lumberjack-bot bot commented Jun 5, 2024 •
edited
Loading

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

nsbarsukov
nsbarsukov commented Jun 5, 2024
View reviewed changes
projects/kit/components/input-date-time/input-date-time.component.ts
@@ -450,6 +450,6 @@ export class TuiInputDateTimeComponent
return tuiDay;
}

return [tuiDay, tuiTime];
return value as [TuiDay, TuiTime];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same as main-branch:

taiga-ui/projects/legacy/components/input-date-time/input-date-time.component.ts

Line 441 in daeba7b

return value as [TuiDay, TuiTime];

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Visit the preview URL for this PR (updated for commit 1e41756):

https://taiga-ui--pr7636-fix-date-time-bug-vo8cekqr.web.app

(expires Thu, 06 Jun 2024 11:58:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@bundlemon BundleMon
Copy link

bundlemon bot commented Jun 5, 2024

BundleMon

Files added (5)
Status Path Size Limits
✅ demo/browser/main.(hash).js
 +392.13KB +10%
✅ demo/browser/vendor.(hash).js
 +214.57KB +10%
✅ demo/browser/runtime.(hash).js
 +41.32KB +10%
✅ demo/browser/polyfills.(hash).js
 +11.25KB +10%
✅ demo/browser/styles.(hash).css
 +1.39KB +10%

Total files change +660.66KB

Groups added (1)
Status Path Size Limits
✅ demo/browser/*..js
 +2.4MB -

Final result: ✅

View report in BundleMon website ➡️

Current branch size history

@splincode splincode merged commit 7ac4291 into v3.x Jun 5, 2024
34 of 35 checks passed
@splincode splincode deleted the fix-date-time-bug branch June 5, 2024 12:29
@taiga-family-bot taiga-family-bot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladimirpotekhin vladimirpotekhin vladimirpotekhin approved these changes

@splincode splincode splincode approved these changes

@waterplea waterplea Awaiting requested review from waterplea waterplea is a code owner

@MarsiBarsi MarsiBarsi Awaiting requested review from MarsiBarsi MarsiBarsi is a code owner

@mdlufy mdlufy Awaiting requested review from mdlufy mdlufy is a code owner

Assignees

@nsbarsukov nsbarsukov

Labels
ready to merge v3
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nsbarsukov @splincode @vladimirpotekhin