Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix custom position accessors #7151

Merged
merged 2 commits into from
Apr 2, 2024
Merged

fix(core): fix custom position accessors #7151

merged 2 commits into from
Apr 2, 2024

Conversation

waterplea
Copy link
Collaborator

Closes #6984

Copy link
Contributor

sweep-ai bot commented Apr 2, 2024

Apply Sweep Rules to your PR?

  • Apply: Refactor large functions to be more modular.

This is an automated message generated by Sweep AI.

Copy link

lumberjack-bot bot commented Apr 2, 2024

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Visit the preview URL for this PR (updated for commit 5a7e3a3):

https://taiga-ui--pr7151-accessor-2phqzvfi.web.app

(expires Wed, 03 Apr 2024 10:57:12 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Apr 2, 2024

BundleMon

Files updated (1)
Status Path Size Limits
demo/browser/main.(hash).js
388.7KB (+27B +0.01%) +10%
Unchanged files (4)
Status Path Size Limits
demo/browser/vendor.(hash).js
214.22KB +10%
demo/browser/runtime.(hash).js
41.11KB +10%
demo/browser/polyfills.(hash).js
11.25KB +10%
demo/browser/styles.(hash).css
1.39KB +10%

Total files change +18B 0%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.39MB (+35B 0%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 93.33333% with 1 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (v3.x@9e7bfa2). Click here to learn what that means.

Files Patch % Lines
projects/core/abstract/position-accessor.ts 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #7151   +/-   ##
=======================================
  Coverage        ?   70.49%           
=======================================
  Files           ?     1098           
  Lines           ?    13128           
  Branches        ?     1863           
=======================================
  Hits            ?     9254           
  Misses          ?     3560           
  Partials        ?      314           
Flag Coverage Δ
addon-charts 71.57% <ø> (?)
addon-doc 60.58% <ø> (?)
addon-mobile 60.50% <ø> (?)
addon-table 60.50% <ø> (?)
addon-tablebars 96.15% <ø> (?)
core 77.62% <93.33%> (?)
kit 70.24% <ø> (?)
summary 70.49% <93.33%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit bdcd37c into v3.x Apr 2, 2024
31 checks passed
@splincode splincode deleted the accessor branch April 2, 2024 11:03
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants