Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk): DirectiveStylesService fix ssr memory leak #6288

Merged
merged 2 commits into from
Dec 22, 2023
Merged

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

part of #6206

What is the new behaviour?

Copy link

lumberjack-bot bot commented Dec 19, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link
Contributor

github-actions bot commented Dec 19, 2023

Visit the preview URL for this PR (updated for commit 8397b7f):

https://taiga-ui--pr6288-memory-leak-okyqsgqj.web.app

(expires Wed, 20 Dec 2023 15:55:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

Copy link

bundlemon bot commented Dec 19, 2023

BundleMon

Files added (5)
Status Path Size Limits
demo/browser/main.(hash).js
+379.7KB +10%
demo/browser/vendor.(hash).js
+212.54KB +10%
demo/browser/runtime.(hash).js
+39.65KB +10%
demo/browser/polyfills.(hash).js
+11.25KB +10%
demo/browser/styles.(hash).css
+1.39KB +10%

Total files change +644.52KB

Groups added (1)
Status Path Size Limits
demo/browser/*..js
+2.31MB -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (v3.x@8108863). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             v3.x    #6288   +/-   ##
=======================================
  Coverage        ?   71.97%           
=======================================
  Files           ?     1457           
  Lines           ?    16026           
  Branches        ?     2286           
=======================================
  Hits            ?    11534           
  Misses          ?     4119           
  Partials        ?      373           
Flag Coverage Δ
addon-charts 71.46% <0.00%> (?)
addon-doc 59.84% <0.00%> (?)
addon-mobile 60.65% <0.00%> (?)
addon-table 60.75% <0.00%> (?)
addon-tablebars 96.15% <0.00%> (?)
cdk 78.64% <0.00%> (?)
core 77.94% <0.00%> (?)
kit 70.20% <0.00%> (?)
summary 71.97% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@splincode splincode merged commit 799e7d6 into v3.x Dec 22, 2023
33 checks passed
@splincode splincode deleted the memory-leak branch December 22, 2023 12:58
This was referenced Jan 31, 2024
This was referenced Feb 20, 2024
This was referenced Mar 19, 2024
This was referenced Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants