Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(experimental): Tooltip add new component #6000

Merged
merged 4 commits into from
Nov 23, 2023
Merged

feat(experimental): Tooltip add new component #6000

merged 4 commits into from
Nov 23, 2023

Conversation

vladimirpotekhin
Copy link
Member

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Refactoring
  • Build or CI related changes
  • Tests related changes
  • Documentation content changes

What is the current behaviour?

Closes #

What is the new behaviour?

Copy link

lumberjack-bot bot commented Nov 17, 2023

Pull request was closed ✔️

All saved screenshots (for current PR) were deleted 🗑️

Copy link

bundlemon bot commented Nov 17, 2023

BundleMon

Files updated (2)
Status Path Size Limits
demo/browser/runtime.(hash).js
40.91KB (+174B +0.42%) +10%
demo/browser/main.(hash).js
343.06KB (+35B +0.01%) +10%
Unchanged files (3)
Status Path Size Limits
demo/browser/vendor.(hash).js
200.75KB +10%
demo/browser/polyfills.(hash).js
18.28KB +10%
demo/browser/styles.(hash).css
1.22KB +10%

Total files change +209B +0.03%

Groups updated (1)
Status Path Size Limits
demo/browser/*..js
2.28MB (+7.11KB +0.31%) -

Final result: ✅

View report in BundleMon website ➡️


Current branch size history | Target branch size history

Copy link
Contributor

github-actions bot commented Nov 17, 2023

Visit the preview URL for this PR (updated for commit d949973):

https://taiga-ui--pr6000-new-tooltip-af09ean0.web.app

(expires Wed, 22 Nov 2023 12:39:16 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 4b5ece1e114386f6a105425ef799091475b249eb

@vladimirpotekhin vladimirpotekhin force-pushed the new-tooltip branch 2 times, most recently from 7ea97a4 to 2388405 Compare November 17, 2023 11:13
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a71d727) 71.94% compared to head (d949973) 71.94%.
Report is 11 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6000   +/-   ##
=======================================
  Coverage   71.94%   71.94%           
=======================================
  Files        1462     1462           
  Lines       15973    15973           
  Branches     2266     2266           
=======================================
  Hits        11491    11491           
  Misses       4111     4111           
  Partials      371      371           
Flag Coverage Δ
addon-charts 71.10% <ø> (ø)
addon-doc 59.62% <ø> (ø)
addon-mobile 60.61% <ø> (ø)
addon-table 60.75% <ø> (ø)
addon-tablebars 90.90% <ø> (ø)
cdk 78.64% <ø> (ø)
core 77.99% <ø> (ø)
kit 70.17% <ø> (ø)
summary 71.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@waterplea waterplea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is going to be a directive with hint as hostDirective in 4.0 )

@splincode splincode merged commit 84cc401 into main Nov 23, 2023
36 checks passed
@splincode splincode deleted the new-tooltip branch November 23, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants